Skip to content
Snippets Groups Projects
Verified Commit f4d380d8 authored by Volker Schukai's avatar Volker Schukai :alien:
Browse files

fix: change order and fix detail-label #245

parent 22ac6a29
No related branches found
No related tags found
No related merge requests found
...@@ -38,49 +38,15 @@ const buttonElementSymbol = Symbol("buttonElement"); ...@@ -38,49 +38,15 @@ const buttonElementSymbol = Symbol("buttonElement");
const buttonEventHandlerSymbol = Symbol("buttonEventHandler"); const buttonEventHandlerSymbol = Symbol("buttonEventHandler");
/** /**
* The Details component is used to show a details. * A Details component
* *
* <img src="./images/details.png"> * @fragments /fragments/components/layout/details/
* *
* Dependencies: the system uses functions of the [monsterjs](https://monsterjs.org/) library * @example /examples/components/layout/details-simple
*
* You can create this control either by specifying the HTML tag <monster-details />` directly in the HTML or using
* Javascript via the `document.createElement('monster-details');` method.
*
* ```html
* <monster-details></monster-details>
* ```
*
* Or you can create this CustomControl directly in Javascript:
*
* ```js
* import '@schukai/component-state/source/details.mjs';
* document.createElement('monster-details');
* ```
*
* The Body should have a class "hidden" to ensure that the styles are applied correctly.
*
* ```css
* body.hidden {
* visibility: hidden;
* }
* ```
*
* @startuml details.png
* skinparam monochrome true
* skinparam shadowing false
* HTMLElement <|-- CustomElement
* CustomElement <|-- Collapse
* Collapse <|-- Details
* @enduml
* *
* @since 3.74.0
* @copyright schukai GmbH * @copyright schukai GmbH
* @memberOf Monster.Components.Layout * @summary A simple but cool Details component
* @summary A simple details component
* @fires Monster.Components.Layout.Details.event:monster-details-before-open
* @fires Monster.Components.Layout.Details.event:monster-details-open
* @fires Monster.Components.Layout.Details.event:monster-details-before-close
* @fires Monster.Components.Layout.Details.event:monster-details-closed
*/ */
class Details extends Collapse { class Details extends Collapse {
/** /**
...@@ -215,13 +181,17 @@ function initButtonLabel() { ...@@ -215,13 +181,17 @@ function initButtonLabel() {
if (this.hasAttribute(ATTRIBUTE_BUTTON_LABEL)) { if (this.hasAttribute(ATTRIBUTE_BUTTON_LABEL)) {
label = this.getAttribute(ATTRIBUTE_BUTTON_LABEL); label = this.getAttribute(ATTRIBUTE_BUTTON_LABEL);
} else { } else {
label = this.innerText; label = this.getOption("labels.button", "Details");
} }
if (!isString(label)) { if (!isString(label)) {
label = ""; label = "";
} }
if (label==="") {
label = this.innerText;
}
label = label.trim(); label = label.trim();
if (label === "") { if (label === "") {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment