Skip to content
Snippets Groups Projects
Verified Commit 00e29577 authored by Volker Schukai's avatar Volker Schukai :alien:
Browse files

fix: update gosec issues #5

parent 35824db2
No related branches found
No related tags found
No related merge requests found
...@@ -111,9 +111,9 @@ func (s *DBSaver) Start() error { ...@@ -111,9 +111,9 @@ func (s *DBSaver) Start() error {
tx.Model(&permJob.Stats).Updates(permJob.Stats) tx.Model(&permJob.Stats).Updates(permJob.Stats)
} }
for _, log := range memLogs { for i, _ := range memLogs {
log.LogID = 0 memLogs[i].LogID = 0
_ = tx.Create(&log) _ = tx.Create(&memLogs[i])
// no error handling, if it fails, it fails // no error handling, if it fails, it fails
} }
......
...@@ -9,12 +9,14 @@ ...@@ -9,12 +9,14 @@
blackbox-terminal blackbox-terminal
coreutils-full coreutils-full
dbeaver dbeaver
dbeaver
delve delve
dialog dialog
drill drill
exa exa
fd fd
fd fd
feh
gcc12 gcc12
gdlv gdlv
git git
...@@ -23,6 +25,7 @@ ...@@ -23,6 +25,7 @@
gnumake gnumake
gnused gnused
go-licenses go-licenses
gosec
go-task go-task
gum gum
httpie httpie
...@@ -34,18 +37,15 @@ ...@@ -34,18 +37,15 @@
memcached memcached
netcat netcat
nixfmt nixfmt
nodePackages.mermaid-cli
openssh
procps procps
ranger ranger
unixtools.xxd unixtools.xxd
dbeaver
unzip unzip
util-linux util-linux
wget wget
zlib zlib
nodePackages.mermaid-cli
feh
openssh
]; ];
# https://devenv.sh/languages/ # https://devenv.sh/languages/
......
...@@ -73,6 +73,7 @@ func ReadJSON(r io.Reader) ([]JobPersistence, error) { ...@@ -73,6 +73,7 @@ func ReadJSON(r io.Reader) ([]JobPersistence, error) {
} }
func ReadYAMLFile(filePath string) ([]JobPersistence, error) { func ReadYAMLFile(filePath string) ([]JobPersistence, error) {
// #nosec
file, err := os.Open(filePath) file, err := os.Open(filePath)
if err != nil { if err != nil {
return nil, err return nil, err
...@@ -82,6 +83,7 @@ func ReadYAMLFile(filePath string) ([]JobPersistence, error) { ...@@ -82,6 +83,7 @@ func ReadYAMLFile(filePath string) ([]JobPersistence, error) {
} }
func ReadJsonFile(filePath string) ([]JobPersistence, error) { func ReadJsonFile(filePath string) ([]JobPersistence, error) {
// #nosec
file, err := os.Open(filePath) file, err := os.Open(filePath)
if err != nil { if err != nil {
return nil, err return nil, err
......
...@@ -62,7 +62,7 @@ func (f *FileOperationRunnable) Run() (RunResult[FileOperationResult], error) { ...@@ -62,7 +62,7 @@ func (f *FileOperationRunnable) Run() (RunResult[FileOperationResult], error) {
}, },
}, nil }, nil
case FileOperationWrite: case FileOperationWrite:
err := os.WriteFile(f.FilePath, []byte(f.Content), 0644) err := os.WriteFile(f.FilePath, []byte(f.Content), 0600)
if err != nil { if err != nil {
return RunResult[FileOperationResult]{Status: ResultStatusFailed}, err return RunResult[FileOperationResult]{Status: ResultStatusFailed}, err
} }
...@@ -85,7 +85,7 @@ func (f *FileOperationRunnable) Run() (RunResult[FileOperationResult], error) { ...@@ -85,7 +85,7 @@ func (f *FileOperationRunnable) Run() (RunResult[FileOperationResult], error) {
}, nil }, nil
case FileOperationAppend: case FileOperationAppend:
fp, err := os.OpenFile(f.FilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) fp, err := os.OpenFile(f.FilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0600)
if err != nil { if err != nil {
return RunResult[FileOperationResult]{Status: ResultStatusFailed}, err return RunResult[FileOperationResult]{Status: ResultStatusFailed}, err
} }
......
...@@ -134,6 +134,7 @@ func (s *SFTPRunnable) Run() (RunResult[SFTPResult], error) { ...@@ -134,6 +134,7 @@ func (s *SFTPRunnable) Run() (RunResult[SFTPResult], error) {
hkCallback = ssh.FixedHostKey(hostKey) hkCallback = ssh.FixedHostKey(hostKey)
} else { } else {
if s.Insecure { if s.Insecure {
// #nosec
hkCallback = ssh.InsecureIgnoreHostKey() hkCallback = ssh.InsecureIgnoreHostKey()
} else { } else {
hkCallback = ssh.FixedHostKey(nil) hkCallback = ssh.FixedHostKey(nil)
...@@ -235,7 +236,7 @@ func (s *SFTPRunnable) copyRemoteToLocal(sftpClient *sftp.Client) ([]string, err ...@@ -235,7 +236,7 @@ func (s *SFTPRunnable) copyRemoteToLocal(sftpClient *sftp.Client) ([]string, err
var filesCopied []string var filesCopied []string
// create destination directory // create destination directory
err := os.MkdirAll(s.DstDir, 0755) err := os.MkdirAll(s.DstDir, 0700)
if err != nil { if err != nil {
return nil, err return nil, err
} }
......
...@@ -74,6 +74,7 @@ func (s *ShellRunnable) Run() (RunResult[ShellResult], error) { ...@@ -74,6 +74,7 @@ func (s *ShellRunnable) Run() (RunResult[ShellResult], error) {
} }
// #nosec
cmd := exec.Command("sh", scriptPath) cmd := exec.Command("sh", scriptPath)
output, err := cmd.Output() output, err := cmd.Output()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment