From 47ce16f998e840cb13856aead7c63cea89ce0924 Mon Sep 17 00:00:00 2001
From: Will McCutchen <will@mccutch.org>
Date: Sat, 24 Jun 2017 19:56:02 -0700
Subject: [PATCH] Allow config via command line flags or env vars
---
cmd/go-httpbin/main.go | 53 ++++++++++++++++++++++++++++++++++++------
1 file changed, 46 insertions(+), 7 deletions(-)
diff --git a/cmd/go-httpbin/main.go b/cmd/go-httpbin/main.go
index 83512f7..db64d33 100644
--- a/cmd/go-httpbin/main.go
+++ b/cmd/go-httpbin/main.go
@@ -1,20 +1,59 @@
package main
import (
+ "flag"
+ "fmt"
"log"
"net/http"
+ "os"
+ "strconv"
"time"
"github.com/mccutchen/go-httpbin/httpbin"
)
+const defaultListenAddr = ":8080"
+
+var (
+ listenAddr string
+ maxMemory int64
+ maxDuration time.Duration
+)
+
func main() {
- h := httpbin.NewHTTPBin(&httpbin.Options{
- MaxMemory: 1024 * 1024 * 5,
- MaxResponseSize: 1024 * 1024,
- MaxResponseTime: 10 * time.Second,
+ flag.StringVar(&listenAddr, "listen", ":8080", "Listen address")
+ flag.Int64Var(&maxMemory, "max-memory", httpbin.DefaultMaxMemory, "Maximum size of request or response, in bytes")
+ flag.DurationVar(&maxDuration, "max-duration", httpbin.DefaultMaxDuration, "Maximum duration a response may take")
+ flag.Parse()
+
+ // Command line flags take precedence over environment vars, so we only
+ // check for environment vars if we have default values for our command
+ // line flags.
+ var err error
+ if maxMemory == httpbin.DefaultMaxMemory && os.Getenv("MAX_MEMORY") != "" {
+ maxMemory, err = strconv.ParseInt(os.Getenv("MAX_MEMORY"), 10, 64)
+ if err != nil {
+ fmt.Printf("invalid value %#v for env var MAX_MEMORY: %s\n", os.Getenv("MAX_MEMORY"), err)
+ flag.Usage()
+ os.Exit(1)
+ }
+ }
+ if maxDuration == httpbin.DefaultMaxDuration && os.Getenv("MAX_DURATION") != "" {
+ maxDuration, err = time.ParseDuration(os.Getenv("MAX_DURATION"))
+ if err != nil {
+ fmt.Printf("invalid value %#v for env var MAX_DURATION: %s\n", os.Getenv("MAX_DURATION"), err)
+ flag.Usage()
+ os.Exit(1)
+ }
+ }
+ if listenAddr == defaultListenAddr && os.Getenv("LISTEN") != "" {
+ listenAddr = os.Getenv("LISTEN")
+ }
+
+ h := httpbin.NewHTTPBinWithOptions(&httpbin.Options{
+ MaxMemory: maxMemory,
+ MaxDuration: maxDuration,
})
- log.Printf("listening on 9999")
- err := http.ListenAndServe(":9999", h.Handler())
- log.Fatal(err)
+ log.Printf("listening on %s", listenAddr)
+ log.Fatal(http.ListenAndServe(listenAddr, h.Handler()))
}
--
GitLab