From b2a23d04ea5d80af051a3cd97bcb0bdf1a6e62ad Mon Sep 17 00:00:00 2001 From: Volker Schukai <volker.schukai@schukai.com> Date: Tue, 18 Feb 2025 12:07:49 +0100 Subject: [PATCH] feat(slider): add more breakpoints --- source/components/form/confirm-button.mjs | 24 ++++++++++++----------- source/components/layout/slider.mjs | 3 +++ 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/source/components/form/confirm-button.mjs b/source/components/form/confirm-button.mjs index a18dbda6f..7e64833df 100644 --- a/source/components/form/confirm-button.mjs +++ b/source/components/form/confirm-button.mjs @@ -104,9 +104,7 @@ class ConfirmButton extends PopperButton { this.hideDialog(); }; - obj["actions"]["confirm"] = (e) => { - throw new Error("this callback must be implemented"); - }; + obj["actions"]["confirm"] = () => {}; return obj; } @@ -119,7 +117,7 @@ class ConfirmButton extends PopperButton { /** * - * @return {Monster.Components.Form.PopperButton} + * @return {PopperButton} */ [assembleMethodSymbol]() { super[assembleMethodSymbol](); @@ -145,7 +143,7 @@ class ConfirmButton extends PopperButton { /** * - * @return {Monster.Components.Form.PopperButton} + * @return {ConfirmButton} */ showDialog() { const confirmButtonClass = this.getOption("classes.confirmButton"); @@ -172,7 +170,7 @@ class ConfirmButton extends PopperButton { * * @param {string} state * @param {number} timeout - * @return {Monster.Components.Form.ConfirmButton} + * @return {ConfirmButton} */ setConfirmButtonState(state, timeout) { this[confirmButtonElementSymbol].setState(state, timeout); @@ -184,7 +182,7 @@ class ConfirmButton extends PopperButton { * * @param {string} message * @param {number} timeout - * @return {Monster.Components.Form.ConfirmButton} + * @return {ConfirmButton} */ showConfirmButtonMessage(message, timeout) { this[confirmButtonElementSymbol].setMessage(message); @@ -216,8 +214,8 @@ function getAction(type) { /** * @private * @return {initEventhandler} - * @fires Monster.Components.Form.PopperButton#monster-confirm - * @fires Monster.Components.Form.PopperButton#monster-confirmed + * @fires ConfirmButton#monster-confirm + * @fires ConfirmButton#monster-confirmed */ function initEventhandler() { this[cancelButtonElementSymbol].setOption( @@ -235,9 +233,13 @@ function initEventhandler() { ); this[confirmButtonElementSymbol].setOption("actions.click", () => { const callback = getAction.call(this, "confirm"); - fireCustomEvent(this, "monster-confirm", {}); + fireCustomEvent(this, "monster-confirm", { + button: this, + }); callback.call(this); - fireCustomEvent(this, "monster-confirmed", {}); + fireCustomEvent(this, "monster-confirmed", { + button: this, + }); }); return this; diff --git a/source/components/layout/slider.mjs b/source/components/layout/slider.mjs index 0293e26c4..afda7029c 100644 --- a/source/components/layout/slider.mjs +++ b/source/components/layout/slider.mjs @@ -160,6 +160,9 @@ class Slider extends CustomElement { slides: { 0: 1, + 600: 2, + 1200: 3, + 1800: 4, }, carousel: { -- GitLab