From 6168acd3b93b8847b3561b15c433d43afb59968b Mon Sep 17 00:00:00 2001 From: Volker Schukai <volker.schukai@schukai.com> Date: Thu, 20 Oct 2022 14:50:37 +0200 Subject: [PATCH] feat new ChangeEventHandler struct --- change_test.go | 16 ++++------------ handler.go | 9 +++++++++ http-handler_test.go | 4 ++-- watch_test.go | 4 ++-- 4 files changed, 17 insertions(+), 16 deletions(-) create mode 100644 handler.go diff --git a/change_test.go b/change_test.go index 7414a81..0e8616f 100644 --- a/change_test.go +++ b/change_test.go @@ -46,14 +46,6 @@ func TestAddRemoveHook(t *testing.T) { } -type ChangeEventTester struct { - callback func(event ChangeEvent) -} - -func (c *ChangeEventTester) Handle(event ChangeEvent) { - c.callback(event) -} - func TestReadmeExample(t *testing.T) { config := struct { @@ -69,8 +61,8 @@ func TestReadmeExample(t *testing.T) { msg := "" var h EventHook - h = &ChangeEventTester{ - callback: func(event ChangeEvent) { + h = &ChangeEventHandler{ + Callback: func(event ChangeEvent) { log := event.Changlog msg = fmt.Sprintf("Change from %s to %s", log[0].From, log[0].To) // for Readme @@ -135,8 +127,8 @@ func TestCangeOnChange(t *testing.T) { counter := 0 var h EventHook - h = &ChangeEventTester{ - callback: func(event ChangeEvent) { + h = &ChangeEventHandler{ + Callback: func(event ChangeEvent) { counter++ closeChan <- true }, diff --git a/handler.go b/handler.go new file mode 100644 index 0000000..eb9bece --- /dev/null +++ b/handler.go @@ -0,0 +1,9 @@ +package configuration + +type ChangeEventHandler struct { + Callback func(event ChangeEvent) +} + +func (c *ChangeEventHandler) Handle(event ChangeEvent) { + c.Callback(event) +} diff --git a/http-handler_test.go b/http-handler_test.go index 7f1cdb5..61b46f6 100644 --- a/http-handler_test.go +++ b/http-handler_test.go @@ -273,8 +273,8 @@ func TestConfigurationServePostJson(t *testing.T) { counter := 0 var h EventHook - h = &ChangeEventTester{ - callback: func(event ChangeEvent) { + h = &ChangeEventHandler{ + Callback: func(event ChangeEvent) { counter++ closeChan <- true }, diff --git a/watch_test.go b/watch_test.go index aafb522..e796abd 100644 --- a/watch_test.go +++ b/watch_test.go @@ -36,8 +36,8 @@ func TestWatch(t *testing.T) { signal := make(chan bool) var h EventHook - h = &ChangeEventTester{ - callback: func(event ChangeEvent) { + h = &ChangeEventHandler{ + Callback: func(event ChangeEvent) { assert.Equal(t, event.Changlog[0].From, "localhost") assert.Equal(t, event.Changlog[0].To, "example.org") signal <- true -- GitLab